2.x: fix Observable.zip to dispose eagerly#5121
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Feb 20, 2017
jbarr21:ObsZipEagerCancel
Merged
2.x: fix Observable.zip to dispose eagerly#5121akarnokd merged 1 commit intoReactiveX:2.xfrom jbarr21:ObsZipEagerCancel
akarnokd merged 1 commit intoReactiveX:2.xfrom
jbarr21:ObsZipEagerCancel
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5121 +/- ##
===========================================
- Coverage 95.17% 95.1% -0.07%
+ Complexity 5566 5564 -2
===========================================
Files 620 620
Lines 40014 40020 +6
Branches 5632 5633 +1
===========================================
- Hits 38082 38062 -20
- Misses 929 941 +12
- Partials 1003 1017 +14
Continue to review full report at Codecov.
|
akarnokd
approved these changes
Feb 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
Observable.zipto dispose the sources outside the serialization loop, just likeFlowable.zipdoes. This allows cancellation even if the serialization loop is busy/blocking inside anonNextemission.In addition, a unit test was added to
Observable.zipas well.Reported in #5111.